----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/#review40314 -----------------------------------------------------------
Ship it! staging/kservice/autotests/pluginlocatortest.cpp <http://git.reviewboard.kde.org/r/112681/#comment29746> remove the if, QVERIFY will "return" on error. staging/kservice/tests/pluginlocator/CMakeLists.txt <http://git.reviewboard.kde.org/r/112681/#comment29748> what is it used for? staging/kservice/tests/pluginlocator/CMakeLists.txt <http://git.reviewboard.kde.org/r/112681/#comment29747> nothing to install here -> remove staging/kservice/tests/pluginlocator/main.cpp <http://git.reviewboard.kde.org/r/112681/#comment29749> where is this option used? ("plugin_s_" vs "name" seems strange, too; or is this a search string that can return multiple results?) staging/kservice/tests/pluginlocator/plugintest.h <http://git.reviewboard.kde.org/r/112681/#comment29750> const QList<...> & staging/kservice/tests/pluginlocator/plugintest.cpp <http://git.reviewboard.kde.org/r/112681/#comment29751> unused staging/kservice/tests/pluginlocator/plugintest.cpp <http://git.reviewboard.kde.org/r/112681/#comment29752> hehe - David Faure On Sept. 18, 2013, 12:12 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112681/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2013, 12:12 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > Tests for KPluginTrader. > > Under autotests/, there's a new test class which runs a variety of queries > using KPluginTrader. There's also a small plugin, which is used to verify > correct metadata querying and loading. It's not installed since QPluginLoader > conveniently contains the working directory when looking for plugins -> it's > found just fine. > > Under tests/, there's a test which will query for a variety of other plugins. > This one is more geared towards performance testing. When run from make test, > it will pass anyway. > > Code can also be found in kdelibs[sebas/pluginlocator]. > > > Diffs > ----- > > staging/kservice/autotests/CMakeLists.txt d341040 > staging/kservice/autotests/fakeplugin.desktop PRE-CREATION > staging/kservice/autotests/fakeplugin.json PRE-CREATION > staging/kservice/autotests/nsaplugin.h PRE-CREATION > staging/kservice/autotests/nsaplugin.cpp PRE-CREATION > staging/kservice/autotests/pluginlocatortest.h PRE-CREATION > staging/kservice/autotests/pluginlocatortest.cpp PRE-CREATION > staging/kservice/tests/CMakeLists.txt 3793aea > staging/kservice/tests/pluginlocator/CMakeLists.txt PRE-CREATION > staging/kservice/tests/pluginlocator/main.cpp PRE-CREATION > staging/kservice/tests/pluginlocator/plugintest.h PRE-CREATION > staging/kservice/tests/pluginlocator/plugintest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112681/diff/ > > > Testing > ------- > > make test =) > > All tests pass on top of my patches. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
