----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/ -----------------------------------------------------------
(Updated Sept. 17, 2013, 11:27 a.m.) Review request for KDE Frameworks and David Faure. Changes ------- data-driven tests as suggested. (There's also a bit of new performance testing code in the not-auto test, which is likely to change, but nevertheless can be useful as-is.) Description ------- Tests for KPluginTrader. Under autotests/, there's a new test class which runs a variety of queries using KPluginTrader. There's also a small plugin, which is used to verify correct metadata querying and loading. It's not installed since QPluginLoader conveniently contains the working directory when looking for plugins -> it's found just fine. Under tests/, there's a test which will query for a variety of other plugins. This one is more geared towards performance testing. When run from make test, it will pass anyway. Code can also be found in kdelibs[sebas/pluginlocator]. Diffs (updated) ----- staging/kservice/autotests/CMakeLists.txt d341040 staging/kservice/autotests/fakeplugin.desktop PRE-CREATION staging/kservice/autotests/fakeplugin.json PRE-CREATION staging/kservice/autotests/nsaplugin.h PRE-CREATION staging/kservice/autotests/nsaplugin.cpp PRE-CREATION staging/kservice/autotests/pluginlocatortest.h PRE-CREATION staging/kservice/autotests/pluginlocatortest.cpp PRE-CREATION staging/kservice/tests/CMakeLists.txt 3793aea staging/kservice/tests/pluginlocator/CMakeLists.txt PRE-CREATION staging/kservice/tests/pluginlocator/createtestdirs.py PRE-CREATION staging/kservice/tests/pluginlocator/main.cpp PRE-CREATION staging/kservice/tests/pluginlocator/plugintest.h PRE-CREATION staging/kservice/tests/pluginlocator/plugintest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112681/diff/ Testing ------- make test =) All tests pass on top of my patches. Thanks, Sebastian Kügler
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
