----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/#review28100 -----------------------------------------------------------
Damn! I forgot a comment in my previous review... I was sure I typed it but apparently not. :-/ It forces us to go through an extra round, I'm really sorry about that, completely my fault. kdeui/actions/kaction.h <http://git.reviewboard.kde.org/r/109019/#comment21023> This signal should stay and keep being emitted for the user code which won't be ported right away. It means you probably need to introduce a private slot connected to globalShortcutChanged() in the KGlobalAccel singleton and reemit if the reported action is this. - Kevin Ottens On Feb. 25, 2013, 9:03 p.m., Valentin Rusu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109019/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2013, 9:03 p.m.) > > > Review request for KDE Frameworks, David Faure and Kevin Ottens. > > > Description > ------- > > KDELibs cleanup task: move global shortcut facilities from KAction to > KGlobalAccel. The second step, registering QActions instead of KActions, will > be done after completing this review. > > > Diffs > ----- > > KDE5PORTING.html e1b41d1 > kdeui/actions/kaction.h ddaa4de > kdeui/actions/kaction.cpp ec63a72 > kdeui/actions/kaction_p.h b50e678 > kdeui/shortcuts/kglobalaccel.h ed68bba > kdeui/shortcuts/kglobalaccel.cpp 36dbab7 > kdeui/shortcuts/kglobalaccel_p.h 04feaba > > Diff: http://git.reviewboard.kde.org/r/109019/diff/ > > > Testing > ------- > > Code compiles > > > Thanks, > > Valentin Rusu > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
