On Saturday 27 Jul 2013 07:49:41 Lindsay Mathieson wrote: > On Sat, 27 Jul 2013 07:58:40 AM Martin Graesslin wrote: > > In case it's about submitting to review board, please have a look at the > > tool "post-review" [1] which is perfect for exactly this situation of > > reviewing patches from a local branch. > > > Yup, not really seeing it being easier. Still have to specify the branch and > revision range by hand, then login to review board to finish filling in the > details and submit. > > All it automates is uploading the diff, which was hardly rocket science in > the > first place. And at the moment its just failing with a "Error uploading diff".
I have to agree. I once (a few years ago) tried using post-review, but gave up because I couldn't understand what it was asking for. Since then I've generated the patch manually and uploaded via the reviewboard webpage. Perhaps post-review has changed since then - I might give it another try sometime. -- David Jarvie. KDE developer. KAlarm author -- http://www.astrojar.org.uk/kalarm >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
