On Saturday 27 July 2013 16:49:41 Lindsay Mathieson wrote: > On Sat, 27 Jul 2013 07:58:40 AM Martin Graesslin wrote: > > In case it's about submitting to review board, please have a look at the > > tool "post-review" [1] which is perfect for exactly this situation of > > reviewing patches from a local branch. > > Yup, not really seeing it being easier. Still have to specify the branch and > revision range by hand, then login to review board to finish filling in the > details and submit. then you are doing something wrong :-) I have a bash alias called "kwin-review" which sets automatically: * review group * branch * review title * review comment * opens the new report in the browser so that I just have to click publish but that could even also be done by the script.
The command I use for this is: post-review -g --branch=master -o --username=graesslin --target-groups=kwin -- repository-url=kde-workspace and for 4.11 it's: post-review -g --branch=KDE/4.11 --parent=KDE/4.11 -o --username=graesslin -- target-groups=kwin --repository-url=kde-workspace with a little bit of git magic one could also auto-generate the parent branch generation. Cheers Martin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
