On Saturday 27 July 2013 17:55:37 Lindsay Mathieson wrote: > On Sat, 27 Jul 2013 09:46:23 AM Martin Graesslin wrote: > > * review title > > * review comment > > Don't see how they could be done automatically since its dependant on the > actually patch. I usually have a range of commits to work with. I don't know your workflow but I tend to write my git commit messages in a way that they also work as the comment for the review request. That's quite similar as the gerrit workflow > > > post-review -g --branch=KDE/4.11 --parent=KDE/4.11 -o --username=graesslin > > -- > > target-groups=kwin --repository-url=kde-workspace > > Another list of obscure command line options I keep having to lookup on top > of the git commands to check my revisions. Still not seeing how its any > easier than uploading a diff to reviewboard. That's why I use a bash alias for it. I also use the upload diff workflow for the repositories I am not regularly working on and uploading the diff takes much more time and many, many more steps. > > Maybe if I was churning out lots of small patches on a regualrly basis, but > thats not the case. I don't see how this matters. Review board can handle one to many patches just fine in one review request.
Cheers Martin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
