On Saturday 06 November 2010 22:54:32 Raphael Kubo da Costa wrote:
> On Saturday, November 06, 2010 01:04:13 pm Milian Wolff wrote:
> > - the FindKGraphViewer.cmake file: I'm a total cmake n00b and this was
> > mostly a "copy&paste" and then "make it work" result. I'm totally unsure
> > whether this is correct or not. Considering that I already got a "it does
> > not work" message [1] (which was before I made the dependency optional),
> > I wonder what might be wrong here...
>
> Our cmake files (the ones in kdelibs at least) are usually BSD-licensed.
> It'd be nice to provide a description of each of the three variables the
> cmake file sets.
>
> If KGraphViewer does not provide pkg-config files, those commented out
> sections can be removed.
>
> The calls to find_path and find_library should take those paths as HINTs
> instead of PATHs, however you should not need to specify them as they are
> probably default ones. Plus, KGRAPHVIEWER_{LIBRARY,INCLUDE}_DIRS appear to
> be empty variables.
>
> If you'd like to have someone more experienced take a look at the file, you
> can ask for help in the kde-buildsystem mailing list.done, thanks. -- Milian Wolff m...@milianw.de http://milianw.de
signature.asc
Description: This is a digitally signed message part.
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
