> On Aug. 23, 2014, 6:26 p.m., Scarlett Clark wrote: > > I had to use this patch to get the frameworks branch to build while > > packaging for Kubuntu. Anyway we can get this pushed to at least frameworks > > branch?
I suggested the commit to frameworks to Luigi back then, but he had some arguments against it at the time. Let's see what he thinks now, as I don't want to override him there. - Marko ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119363/#review65099 ----------------------------------------------------------- On July 20, 2014, 12:08 a.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119363/ > ----------------------------------------------------------- > > (Updated July 20, 2014, 12:08 a.m.) > > > Review request for KDE Base Apps, Luigi Toscano and Nicolás Alvarez. > > > Repository: kde-baseapps > > > Description > ------- > > This suggests to upgrade the docbook DTD from 4.2 to 4.5. > > > Diffs > ----- > > doc/konqueror/index.docbook a1f8565404be0289b51af37df1687e0911a01fe5 > dolphin/docs/index.docbook 5fe85f5d130e3723af556fb02b53970206d1c765 > kdepasswd/docs/index.docbook 2ecef470ac8a9384b7aeb16f123f834d040ee375 > kfind/docs/index.docbook d46dfa4138991a356eec32a7043a883150eb81c2 > kfind/docs/man-kfind.1.docbook ef2eb3b9fb1ed1a84ae33fa631b0295a029444e0 > > Diff: https://git.reviewboard.kde.org/r/119363/diff/ > > > Testing > ------- > > Builds/installs fine (if one doesn't use any white-space in DATA_INSTALL_DIR > path) > > > Thanks, > > Marko Käning > >
