> On Ago. 23, 2014, 6:26 p.m., Scarlett Clark wrote: > > I had to use this patch to get the frameworks branch to build while > > packaging for Kubuntu. Anyway we can get this pushed to at least frameworks > > branch? > > Marko Käning wrote: > I suggested the commit to frameworks to Luigi back then, but he had some > arguments against it at the time. > Let's see what he thinks now, as I don't want to override him there. > > Luigi Toscano wrote: > I don't find the discussion but I think I wrote something on the line of: > let's see if it can be made working without this, because, if kdelibs4support > is installed, this should work. Scarlett, can you please confirm that it does > not compile even if kdelibs4support is installed in the buildroot? Could you > please paste the error? > > Luigi Toscano wrote: > To be clear: I'm not against pushing this, you can commit it if no other > solutions works and it's the expected step anyway for a complete porting > (without kdelibs4support). My point is that the backward compatibility should > work; if not, I spent quite some time working on nothing. > > Scarlett Clark wrote: > http://goo.gl/mLRi02 I pasted my build depends and my failed build. > > Luigi Toscano wrote: > Sotty, I totally missed this comment! I think you miss kdelibs4support in > the build dependencies; with that package installed, compilation should work. > > Scarlett Clark wrote: > I already spoke to you today, but I just confirmed > libkf5kdelibs4support-dev (>= 5.1.0) is in the build depends.
Argh! Thanks for rechecking; I will try to solve this during Akademy. - Luigi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119363/#review65099 ----------------------------------------------------------- On Ago. 24, 2014, 6:33 p.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119363/ > ----------------------------------------------------------- > > (Updated Ago. 24, 2014, 6:33 p.m.) > > > Review request for KDE Base Apps, Luigi Toscano and Nicolás Alvarez. > > > Repository: kde-baseapps > > > Description > ------- > > This suggests to upgrade the docbook DTD from 4.2 to 4.5. > > --- > > There is still an open issue here: > > Spaces in DATA_INSTALL_DIR need to be handled properly, so that the path in > the DTD file > > /Library/Application\ Support/kf5/kdoctools/customization/dtd/kdex.dtd > > is correctly set, i.e. using "%20" instead of a space. > > > Diffs > ----- > > doc/konqueror/index.docbook a1f8565404be0289b51af37df1687e0911a01fe5 > dolphin/docs/index.docbook 5fe85f5d130e3723af556fb02b53970206d1c765 > kdepasswd/docs/index.docbook 2ecef470ac8a9384b7aeb16f123f834d040ee375 > kfind/docs/index.docbook d46dfa4138991a356eec32a7043a883150eb81c2 > kfind/docs/man-kfind.1.docbook ef2eb3b9fb1ed1a84ae33fa631b0295a029444e0 > > Diff: https://git.reviewboard.kde.org/r/119363/diff/ > > > Testing > ------- > > Builds/installs fine (if one doesn't use any white-space in DATA_INSTALL_DIR > path) > > > Thanks, > > Marko Käning > >
