> On July 19, 2014, 2:18 p.m., Luigi Toscano wrote: > > Where does kdelibs4support install the compatibility docbook elements? For > > example, dtd/kdex.dtd.cmake, and what is its content? It should install > > them on the same directory as the kdoctools files (usually), but even if > > they are installed in a different prefix like in the CI environment, it > > should work, as paths in dtd/kdex.dtd.cmake are fixed accordingly (see > > https://git.reviewboard.kde.org/r/116670 > > > > Anyway, as you can see https://git.reviewboard.kde.org/r/11678 all the > > paths where catalogues are installed are considered, BUT it relies on > > QStandardPaths; that's why I think it could be related with the other > > QStandardPaths issues. > > See also the questions at the end of review 116670. > > > > I would suggest to continue the discussion on that mailing list thread. > > > > (as a side note: I've seen those commits with a commit message like "Fix > > compilation on MacOSX", I would rather use "Part docbook to 4.5" and the > > comment about the compilation on MacOSX in the other lines, as this is not > > real a fix but a workaround).
Yes, you are right, it would have made sense to write "port docbook to 4.5" instead of fixing being workarounding. :) (Turns out I was editing my below review comment when you had already sent yours - which I hadn't seen yet.) OK, I'll return to the ML thread as soon as there are news. - Marko ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119363/#review62690 ----------------------------------------------------------- On July 19, 2014, 2:09 p.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119363/ > ----------------------------------------------------------- > > (Updated July 19, 2014, 2:09 p.m.) > > > Review request for KDE Base Apps, Luigi Toscano and Nicolás Alvarez. > > > Repository: kde-baseapps > > > Description > ------- > > I need to upgrade the docbook DTD from 4.2 to 4.5 to be able to build this > project. > > --- > > I have done similar checkins for other projects like step and kgeography, but > I am unsure whether this is really the way to go, although Nicolas made the > same for kalgebra lately. > > Luigi wrote in > http://mail.kde.org/pipermail/kde-frameworks-devel/2014-July/017471.html that > this should work with kdelibs4support installed. It is installed on the > OSX/CI system, but still it doesn't work. > > --- > > So, perhaps it is worthwhile diagnosing what goes wrong there instead of > committing this RR?! > > What can I do to let kdoctools tell me where exactly it expects to find its > catalogues? > > Let me add that kdoctools definitely expects its files in > "/Library/Application Support/kf5/kdoctools" in my case, because I had to > copy them to there manually after successfully building kdoctools: > > ```bash > $ ls /Library/Application\ Support/kf5/kdoctools > customization > ``` > > Also note, that I use this global setting for configurePlatformArgs: > -DDATA_INSTALL_DIR="Library/Application Support". > > > Diffs > ----- > > doc/konqueror/index.docbook a1f8565404be0289b51af37df1687e0911a01fe5 > dolphin/docs/index.docbook 5fe85f5d130e3723af556fb02b53970206d1c765 > kdepasswd/docs/index.docbook 2ecef470ac8a9384b7aeb16f123f834d040ee375 > kfind/docs/index.docbook d46dfa4138991a356eec32a7043a883150eb81c2 > kfind/docs/man-kfind.1.docbook ef2eb3b9fb1ed1a84ae33fa631b0295a029444e0 > > Diff: https://git.reviewboard.kde.org/r/119363/diff/ > > > Testing > ------- > > Builds/installs fine > > > Thanks, > > Marko Käning > >
