https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #38 from Lubos Lunak <l.lu...@kde.org> ---
> But the error handling in get_debug_addr_entry looks off.
> The second argument is DW_FORM form. But it is given either a DW_FORM,
> DW_LLE or DW_LRE.
> I think it would be better if the second argument would be a const HChar*.

You're right, too much copy&paste. Updated (but not using const HChar*, as I
find it inefficient to go through a large switch for every call even though it
normally wouldn't be used).

> imho to use #if defined(VG_BIGENDIAN) instead of doing a runtime trick.

Updated.

> Is the big endian variant correct?

I don't have actual big endian HW, but I think it is. The input is 3-byte
bigendian that needs byte-by-byte handling, not the output.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to