cmccabe commented on code in PR #12036:
URL: https://github.com/apache/kafka/pull/12036#discussion_r849729793
##########
clients/src/main/java/org/apache/kafka/clients/admin/UpdateFeaturesOptions.java:
##########
@@ -26,4 +26,14 @@
*/
@InterfaceStability.Evolving
public class UpdateFeaturesOptions extends
AbstractOptions<UpdateFeaturesOptions> {
+ private boolean validateOnly = false;
+
+ public boolean validateOnly() {
+ return validateOnly;
+ }
+
+ public UpdateFeaturesOptions dryRun(boolean dryRun) {
Review Comment:
Changing the name of the parameter doesn't change the binary compatibility,
so it should be fine. One advantage of Java not having named parameters, I
guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]