cmccabe commented on code in PR #12036:
URL: https://github.com/apache/kafka/pull/12036#discussion_r848898186
##########
clients/src/main/java/org/apache/kafka/clients/admin/FeatureUpdate.java:
##########
@@ -23,33 +23,92 @@
*/
public class FeatureUpdate {
private final short maxVersionLevel;
- private final boolean allowDowngrade;
+ private final DowngradeType downgradeType;
+
+ public enum DowngradeType {
Review Comment:
It's kind of awkward to upgrade by setting DowngradeType = NONE. Can we have
this be UpdateType and have UPGRADE, DOWNGRADE, UNSAFE_DOWNGRADE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
