cmccabe commented on code in PR #12036: URL: https://github.com/apache/kafka/pull/12036#discussion_r848908269
########## core/src/main/scala/kafka/server/BrokerServer.scala: ########## @@ -153,6 +150,8 @@ class BrokerServer( var metadataPublisher: BrokerMetadataPublisher = null + var brokerFeatures: BrokerFeatures = null Review Comment: Hmm, since this corresponds to the features supported by the broker, it seems like this should be known statically at compile time. So I don't see an advantage to initializing it dynamically. If we want to support simulating old brokers in junit tests, we should add this as a constructor parameter (possibly one which defaults to the latest versions of everything if you want to get fancy....) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
