kkonstantine commented on a change in pull request #11908:
URL: https://github.com/apache/kafka/pull/11908#discussion_r835510543



##########
File path: docs/connect.html
##########
@@ -48,6 +48,8 @@ <h4><a id="connect_running" href="#connect_running">Running 
Kafka Connect</a></h
         <li><code>bootstrap.servers</code> - List of Kafka servers used to 
bootstrap connections to Kafka</li>
         <li><code>key.converter</code> - Converter class used to convert 
between Kafka Connect format and the serialized form that is written to Kafka. 
This controls the format of the keys in messages written to or read from Kafka, 
and since this is independent of connectors it allows any connector to work 
with any serialization format. Examples of common formats include JSON and 
Avro.</li>
         <li><code>value.converter</code> - Converter class used to convert 
between Kafka Connect format and the serialized form that is written to Kafka. 
This controls the format of the values in messages written to or read from 
Kafka, and since this is independent of connectors it allows any connector to 
work with any serialization format. Examples of common formats include JSON and 
Avro.</li>
+        <li><code>plugin.path</code> (default <code>empty</code>) - a list of 
paths that contain
+            plugins (connectors, converters, transformations). For the purpose 
of quick starts users will have to add the path that contains the 
FileStreamSourceConnector and FileStreamSinkConnector packaged in 
<code>connect-file-"version".jar</code>, because these connectors are not 
included by default to the <code>CLASSPATH</code> or the 
<code>plugin.path</code> of the Connect worker.</li>

Review comment:
       Thanks for the comment @rhauch 
   One note that I have is that I wouldn't recommend adding the relative path 
even if it works, because it possibly doesn't lead to robust deployments. 
`plugin.path` works when following symlinks so that can help. 
   
   `plugin.path` works with uber-jars but I wouldn't necessarily consider 
`connect-file-<version>.jar` an uber jar. I'd recommend the mainstream way 
which is to add the parent directory of any directories containing connector 
jars. Let me try to see how an example looks like here, because that's already 
just a bullet point. 
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to