kkonstantine commented on a change in pull request #11908:
URL: https://github.com/apache/kafka/pull/11908#discussion_r837926635
##########
File path: docs/quickstart.html
##########
@@ -173,7 +173,11 @@ <h4 class="anchor-heading">
</p>
<p>
- First, we'll start by creating some seed data to test with:
+ First, make sure to add <code
class="language-bash">connect-file-{{fullDotVersion}}.jar</code> to the
<code>plugin.path</code> property in the Connect worker's configuration (see <a
href="#connectconfigs_plugin.path">plugin.path</a> for examples).
+ </p>
Review comment:
I agree. Better to add this example to the quick start itself rather
than the config.
Again, my dilemma was regarding whether we should suggest a relative path +
uber jar value which is not typical for production even on the quick start or
direct users to the documentation of the property. I'm also a fan of quick
starts that demonstrate a working example step-by-step. So, after your comment
I've changed the quick start doc to contain an example. Let me know how it
looks after that change when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
