rhauch commented on a change in pull request #11908:
URL: https://github.com/apache/kafka/pull/11908#discussion_r834525760
##########
File path: tests/kafkatest/services/connect.py
##########
@@ -279,12 +282,34 @@ def append_to_environment_variable(self, envvar, value):
env_opts = "\"%s %s\"" % (env_opts.strip('\"'), value)
self.environment[envvar] = env_opts
+ def append_filestream_connectors_to_classpath(self):
Review comment:
This method is actually returning a _command_ to add the file connectors
jar to the classpath. Should the method name reflect this?
##########
File path: docs/connect.html
##########
@@ -48,6 +48,8 @@ <h4><a id="connect_running" href="#connect_running">Running
Kafka Connect</a></h
<li><code>bootstrap.servers</code> - List of Kafka servers used to
bootstrap connections to Kafka</li>
<li><code>key.converter</code> - Converter class used to convert
between Kafka Connect format and the serialized form that is written to Kafka.
This controls the format of the keys in messages written to or read from Kafka,
and since this is independent of connectors it allows any connector to work
with any serialization format. Examples of common formats include JSON and
Avro.</li>
<li><code>value.converter</code> - Converter class used to convert
between Kafka Connect format and the serialized form that is written to Kafka.
This controls the format of the values in messages written to or read from
Kafka, and since this is independent of connectors it allows any connector to
work with any serialization format. Examples of common formats include JSON and
Avro.</li>
+ <li><code>plugin.path</code> (default <code>empty</code>) - a list of
paths that contain
+ plugins (connectors, converters, transformations). For the purpose
of quick starts users will have to add the path that contains the
FileStreamSourceConnector and FileStreamSinkConnector packaged in
<code>connect-file-"version".jar</code>, because these connectors are not
included by default to the <code>CLASSPATH</code> or the
<code>plugin.path</code> of the Connect worker.</li>
Review comment:
Previous list item paragraphs are on a single line, and it's probably
useful to keep that formatting style. Also, a few nits:
```suggestion
<li><code>plugin.path</code> (default <code>empty</code>) - a list
of paths that contain Connect plugins (connectors, converters,
transformations). Before running quick starts, users must add the relative or
absolute path that contains the example FileStreamSourceConnector and
FileStreamSinkConnector packaged in <code>connect-file-"version".jar</code>,
because these connectors are not included by default to the
<code>CLASSPATH</code> or the <code>plugin.path</code> of the Connect
worker.</li>
```
I also have a few questions.
1. Should the path include the _JAR file_ or the _directory that contains
the JAR file_?
2. Would it be useful if we supplied an example `plugin.path` line to add?
I've built the distribution with this PR branch, and verified that the
quickstart running the standalone worker fails if the file connectors are not
in the `plugin.path`, but adding `plugin.path=libs/connect-file-<version>.jar`
does work as long as the quickstart is run from the installation directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
