hachikuji commented on a change in pull request #11616:
URL: https://github.com/apache/kafka/pull/11616#discussion_r806399392
##########
File path: config/kraft/server.properties
##########
@@ -31,22 +31,24 @@ controller.quorum.voters=1@localhost:9093
############################# Socket Server Settings
#############################
-# The address the socket server listens on. It will get the value returned from
-# java.net.InetAddress.getCanonicalHostName() if not configured.
+# The address the socket server listens on.
+# This is required for combined role(i.e. process.roles=broker,controller)
node to set the listeners at least for controller
Review comment:
How about this?
> Combined nodes (i.e. those with `process.roles=broker,controller`) must
list the controller listener here at a minimum. If the broker listener is not
defined, the default listener will use a host name will be equal to the value
of `#java.net.InetAddress.getCanonicalHostName()`, with `PLAINTEXT` listener
name, and port 9092.
By the way, I find this approach of allowing a default only for "broker" a
bit messy. For a separate patch, but maybe we should require both listeners to
be explicitly provided. What do you think?
##########
File path: config/kraft/controller.properties
##########
@@ -31,22 +31,17 @@ controller.quorum.voters=1@localhost:9093
############################# Socket Server Settings
#############################
-# The address the socket server listens on. It will get the value returned from
-# java.net.InetAddress.getCanonicalHostName() if not configured.
+# The address the socket server listens on.
+# Note that only the controller listeners are allowed here when
`process.roles=controller`.
# FORMAT:
# listeners = listener_name://host_name:port
# EXAMPLE:
# listeners = PLAINTEXT://your.host.name:9092
-listeners=PLAINTEXT://:9093
+listeners=CONTROLLER://:9093
Review comment:
I wonder if it's helpful to have a note about consistency between this
and `controller.quorum.voters`?
##########
File path: config/producer.properties
##########
@@ -23,7 +23,7 @@ bootstrap.servers=localhost:9092
# specify the compression codec for all data generated: none, gzip, snappy,
lz4, zstd
compression.type=none
-# name of the partitioner class for partitioning events; default partition
spreads data randomly
+# name of the partitioner class for partitioning records; The default uses
"sticky" partitioning logic, which attempts to fill batches sent to each broker
in order to improve throughput.
Review comment:
Small improvement? I thought we should say something about balance.
> The default uses "sticky" partitioning logic which spreads the load evenly
between partitions, but improves throughput by attempting to fill the batches
sent to each partition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
