showuon commented on a change in pull request #11616:
URL: https://github.com/apache/kafka/pull/11616#discussion_r806811337
##########
File path: config/kraft/controller.properties
##########
@@ -31,22 +31,17 @@ controller.quorum.voters=1@localhost:9093
############################# Socket Server Settings
#############################
-# The address the socket server listens on. It will get the value returned from
-# java.net.InetAddress.getCanonicalHostName() if not configured.
+# The address the socket server listens on.
+# Note that only the controller listeners are allowed here when
`process.roles=controller`.
# FORMAT:
# listeners = listener_name://host_name:port
# EXAMPLE:
# listeners = PLAINTEXT://your.host.name:9092
-listeners=PLAINTEXT://:9093
+listeners=CONTROLLER://:9093
Review comment:
Good suggestion. Updated.
##########
File path: config/producer.properties
##########
@@ -23,7 +23,7 @@ bootstrap.servers=localhost:9092
# specify the compression codec for all data generated: none, gzip, snappy,
lz4, zstd
compression.type=none
-# name of the partitioner class for partitioning events; default partition
spreads data randomly
+# name of the partitioner class for partitioning records; The default uses
"sticky" partitioning logic, which attempts to fill batches sent to each broker
in order to improve throughput.
Review comment:
a ha, you're right. I only focus on the comparison between sticky and
round-robin partitioner. Updated.
##########
File path: config/kraft/server.properties
##########
@@ -31,22 +31,24 @@ controller.quorum.voters=1@localhost:9093
############################# Socket Server Settings
#############################
-# The address the socket server listens on. It will get the value returned from
-# java.net.InetAddress.getCanonicalHostName() if not configured.
+# The address the socket server listens on.
+# This is required for combined role(i.e. process.roles=broker,controller)
node to set the listeners at least for controller
Review comment:
> For a separate patch, but maybe we should require both listeners to be
explicitly provided. What do you think?
Agree. I'll file a jira for it later. Thanks.
##########
File path: config/kraft/server.properties
##########
@@ -31,22 +31,24 @@ controller.quorum.voters=1@localhost:9093
############################# Socket Server Settings
#############################
-# The address the socket server listens on. It will get the value returned from
-# java.net.InetAddress.getCanonicalHostName() if not configured.
+# The address the socket server listens on.
+# This is required for combined role(i.e. process.roles=broker,controller)
node to set the listeners at least for controller
Review comment:
[KAFKA-13667](https://issues.apache.org/jira/browse/KAFKA-13667) is
created for this improvement. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
