hachikuji commented on a change in pull request #11616:
URL: https://github.com/apache/kafka/pull/11616#discussion_r805070981
##########
File path: config/kraft/controller.properties
##########
@@ -31,21 +31,16 @@ controller.quorum.voters=1@localhost:9093
############################# Socket Server Settings
#############################
-# The address the socket server listens on. It will get the value returned from
-# java.net.InetAddress.getCanonicalHostName() if not configured.
+# The address the socket server listens on. If not configured, the host name
will be equal to the value of
+# java.net.InetAddress.getCanonicalHostName(), with PLAINTEXT listener name,
and port 9092.
# FORMAT:
# listeners = listener_name://host_name:port
# EXAMPLE:
# listeners = PLAINTEXT://your.host.name:9092
listeners=PLAINTEXT://:9093
Review comment:
Could we use CONTROLLER as in broker.properties?
##########
File path: config/kraft/README.md
##########
@@ -35,6 +35,9 @@ Formatting /tmp/kraft-combined-logs
If you are using multiple nodes, then you should run the format command on
each node. Be sure to use the same cluster ID for each one.
+This example configures the node as both a broker and controller (i.e.
`process.roles=broker,controller`). It is also possible to run the broker and
controller nodes separately.
+please see
[here](https://github.com/apache/kafka/blob/trunk/config/kraft/broker.properties)
and
[here](https://github.com/apache/kafka/blob/trunk/config/kraft/controller.properties)
for example configurations.
Review comment:
nit: capitalize "Please"
##########
File path: config/kraft/controller.properties
##########
@@ -31,21 +31,16 @@ controller.quorum.voters=1@localhost:9093
############################# Socket Server Settings
#############################
-# The address the socket server listens on. It will get the value returned from
-# java.net.InetAddress.getCanonicalHostName() if not configured.
+# The address the socket server listens on. If not configured, the host name
will be equal to the value of
+# java.net.InetAddress.getCanonicalHostName(), with PLAINTEXT listener name,
and port 9092.
Review comment:
Is this another case that we need to fix? I think we need to have the
controller listener here. Perhaps we should even say that _only_ the controller
listeners are allowed here when `process.roles=controller`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
