[GitHub] [kafka] dajac commented on a change in pull request #8933: KAFKA-10163; Throttle Create Topic, Create Partition and Delete Topic Operations (KIP-599, Part I, Broker Changes)

[GitBox]

dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456275664



##########
File path: core/src/main/scala/kafka/server/ClientRequestQuotaManager.scala
##########
@@ -20,21 +20,32 @@ import java.util.concurrent.TimeUnit
 
 import kafka.network.RequestChannel
 import org.apache.kafka.common.MetricName
+import org.apache.kafka.common.metrics.Sensor.QuotaEnforcementType
 import org.apache.kafka.common.metrics._
 import org.apache.kafka.common.utils.Time
 import org.apache.kafka.server.quota.ClientQuotaCallback
 
 import scala.jdk.CollectionConverters._
 
+object ClientRequestQuotaManager {
+  val QuotaRequestPercentDefault = Int.MaxValue.toDouble
+  val NanosToPercentagePerSecond = 100.0 / TimeUnit.SECONDS.toNanos(1)
+}
 
 class ClientRequestQuotaManager(private val config: ClientQuotaManagerConfig,
                                 private val metrics: Metrics,
                                 private val time: Time,
-                                threadNamePrefix: String,
-                                quotaCallback: Option[ClientQuotaCallback])
-                                extends ClientQuotaManager(config, metrics, 
QuotaType.Request, time, threadNamePrefix, quotaCallback) {
-  val maxThrottleTimeMs = 
TimeUnit.SECONDS.toMillis(this.config.quotaWindowSizeSeconds)
-  def exemptSensor = getOrCreateSensor(exemptSensorName, exemptMetricName)
+                                private val threadNamePrefix: String,
+                                private val quotaCallback: 
Option[ClientQuotaCallback])
+    extends ClientQuotaManager(config, metrics, QuotaType.Request, 
QuotaEnforcementType.PERMISSIVE,
+      time, threadNamePrefix, quotaCallback) {
+
+  private val maxThrottleTimeMs = 
TimeUnit.SECONDS.toMillis(this.config.quotaWindowSizeSeconds)
+  private val exemptMetricName = metrics.metricName("exempt-request-time",
+    QuotaType.Request.toString, "Tracking exempt-request-time utilization 
percentage")
+  private val exemptSensorName = "exempt-" + QuotaType.Request

Review comment:
       Yes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org