[GitHub] [kafka] dajac commented on a change in pull request #8933: KAFKA-10163; Throttle Create Topic, Create Partition and Delete Topic Operations (KIP-599, Part I, Broker Changes)

[GitBox]

dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456267262



##########
File path: core/src/main/scala/kafka/server/AdminManager.scala
##########
@@ -101,12 +148,6 @@ class AdminManager(val config: KafkaConfig,
         if (nullConfigs.nonEmpty)
           throw new InvalidRequestException(s"Null value not supported for 
topic configs : ${nullConfigs.mkString(",")}")
 
-        val configs = new Properties()
-        topic.configs.forEach { entry =>
-          configs.setProperty(entry.name, entry.value)
-        }
-        LogConfig.validate(configs)

Review comment:
       This is done in `validateTopicCreate` (last line). Actually, I found out 
that we were validating the `LogConfig` twice before.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org