ableegoldman commented on a change in pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#discussion_r456615189



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##########
@@ -265,7 +265,7 @@ public void 
shouldNotAllowToResetWhenIntermediateTopicAbsent() throws Exception
     public void testResetWhenLongSessionTimeoutConfiguredWithForceOption() 
throws Exception {

Review comment:
       Okay, maybe I gave the wrong advise here and instead of consolidating 
the two classes we should have separated them. 
   
   WDYT about just moving all but the three tests that we want to run with SSL 
out of `AbstractResetIntegrationTest` and into `ResetIntegrationTest` instead? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to