mjsax commented on PR #22213:
URL: https://github.com/apache/kafka/pull/22213#issuecomment-5081332388
Thanks for the PR. Merged to `trunk` to meet feature freeze deadline and
unblock other work.
A few thing, I would like to get addresses as follow up PR:
- Use `ConfigDef.parseType(name, value, Type.LIST)` in
`GroupCoordinatorConfig.rawRackAwareAssignmentTags()`
and `GroupConfig.validateNoDuplicateRackAwareAssignmentTags()` instead of
hand-rolling `\s*,\s*`.
Also removes the `(String)` cast on `originals()`.
- `streamsGroupAssignmentConfigs()` joins the tags into a string, and the
MISSING_CLIENT_TAGS check
splits it back apart in the same heartbeat. Read the `List<String>`
directly.
- `num.standby.replicas` is still written unconditionally, so the "omit
default-valued configs"
fix only covers the new config and the next one added hits the upgrade
epoch bump again.
- Add a test that a v0 `StreamsGroupHeartbeat` never receives status code 6.
- Constants for `"rack.aware.assignment.tags"` and `"num.standby.replicas"`.
- Docs: KIP-1071 progress entry in `docs/streams/upgrade-guide.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
