gabriellefu commented on code in PR #22213:
URL: https://github.com/apache/kafka/pull/22213#discussion_r3640711013
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -467,6 +488,30 @@ public static void validate(
);
}
+ /**
+ * Rejects an alterConfigs request whose rack-aware assignment tags
contain duplicate keys, inspecting the
+ * raw value because {@link ConfigDef} removes duplicates from LIST values
before they can be validated.
+ *
+ * @param newGroupConfig The new unparsed group config overrides.
+ */
+ private static void validateNoDuplicateRackAwareAssignmentTags(Map<String,
?> newGroupConfig) {
Review Comment:
sounds good, i'll update it to be all strings. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
