gabriellefu commented on code in PR #22213:
URL: https://github.com/apache/kafka/pull/22213#discussion_r3640736251
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2354,6 +2357,27 @@ private CoordinatorResult<StreamsGroupHeartbeatResult,
CoordinatorRecord> stream
)
));
+ String rackAwareTagsValue =
currentAssignmentConfigs.getOrDefault("rack.aware.assignment.tags", "");
+ // The MISSING_CLIENT_TAGS status (code 6) requires version 1 of the
RPC: version 0 clients
+ // throw on unknown status codes, so it must not be sent to them.
+ if (requestApiVersion >= 1 && !rackAwareTagsValue.isEmpty()) {
+ List<String> requiredTags =
Arrays.asList(rackAwareTagsValue.split(",", -1));
Review Comment:
ok sounds good, i just wondering if there any other types we need to
validate, I remember we said the assignor should be responsible whether their
tag names are correct or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
