squah-confluent commented on code in PR #21508:
URL: https://github.com/apache/kafka/pull/21508#discussion_r2838819751
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroupMember.java:
##########
@@ -66,6 +69,8 @@ public static class Builder {
private Map<Uuid, Set<Integer>> assignedPartitions = Map.of();
private Map<Uuid, Set<Integer>> partitionsPendingRevocation = Map.of();
private ConsumerGroupMemberMetadataValue.ClassicMemberMetadata
classicMemberMetadata = null;
+ private Map<Uuid, Map<Integer, Integer>> assignedPartitionsWithEpochs
= Map.of();
Review Comment:
> `assignedPartitions` is part of the fields inherited from
`ModernGroupMember` that `ShareGroupMember` also uses
I'm no longer convinced `assignedPartitions` in `ModernGroupMember` is
useful, considering we have three group types, consumer, share and streams, all
wanting different assignment types. I would leave `assignedPartitions` in place
for now but would like to see it removed eventually.
> `partitionsPendingRevocation`
All the callers look to be consumer group-specific, so we should be able to
adjust them to use the map<partition, epoch>s without impacting share groups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
