gongxuanzhang commented on code in PR #19489:
URL: https://github.com/apache/kafka/pull/19489#discussion_r2629420120
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##########
@@ -2686,14 +2687,12 @@ public void testResetNextBatchExpiry() throws Exception
{
inOrder.verify(client, atLeastOnce()).newClientRequest(anyString(),
any(), anyLong(), anyBoolean(), anyInt(), any());
inOrder.verify(client, atLeastOnce()).send(any(), anyLong());
inOrder.verify(client).poll(eq(0L), anyLong());
- inOrder.verify(client).poll(eq(accumulator.getDeliveryTimeoutMs()),
anyLong());
Review Comment:
During the process, poll is invoked with (maxLong - now), so I think the
test should use gte(maxLong - System.currentTimeMillis()) for verification.
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
