gongxuanzhang commented on code in PR #19489:
URL: https://github.com/apache/kafka/pull/19489#discussion_r2625402300


##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##########
@@ -2642,11 +2645,11 @@ public void testExpiredBatchDoesNotRetry() throws 
Exception {
     }
 
     @Test
-    public void testExpiredBatchDoesNotSplitOnMessageTooLargeError() throws 
Exception {
+    public void testBatchDoesNotSplitOnMessageTooLargeError() throws Exception 
{

Review Comment:
   Now we no longer expire in-flight request batches, so I’m not sure how to 
create an expired batch in order to test whether it gets split.
   Can I just crudely sleep for the delivery timeout?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to