mimaison commented on PR #19397: URL: https://github.com/apache/kafka/pull/19397#issuecomment-3460773805
I agree that monitoring for very short lived instances (clients/brokers) is not very valuable. So adding support for KIP-877 does not really make sense. As you found, in Connect the ConfigProvider instances can be reused while the Connect runtime is running. In this case monitoring has more value. However I think it would be confusing to have different behaviors depending on where a ConfigProvider is used. For example if you build a ConfigProvider that has metrics, they would only be emitted when running in Connect and not in other components. I wonder if we should just decide to not add KIP-877 to ConfigProvider. If there is demand for Connect we can reconsider in the future but that does not seem to be the case at the moment. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
