mimaison commented on code in PR #19397:
URL: https://github.com/apache/kafka/pull/19397#discussion_r2470357736
##########
clients/src/main/java/org/apache/kafka/common/config/provider/ConfigProvider.java:
##########
@@ -29,6 +29,11 @@
* <p>Kafka Connect discovers implementations of this interface using the Java
{@link java.util.ServiceLoader} mechanism.
* To support this, implementations of this interface should also contain a
service provider configuration file in
* {@code
META-INF/services/org.apache.kafka.common.config.provider.ConfigProvider}.
+ * <p>Implement {@link org.apache.kafka.common.metrics.Monitorable} to enable
the config provider to register metrics.
+ * The following tags are automatically added to all metrics registered:
<code>config</code> set to
+ * <code>config.providers</code>, <code>class</code> set to the ConfigProvider
class name,
+ * and <code>provider</code> set to the provider name. Note that MirrorMaker
will not reflect this behavior until
+ * KAFKA-19149 is implemented.
Review Comment:
I'm not sure your understanding is correct.
[KAFKA-19149](https://issues.apache.org/jira/browse/KAFKA-19149) is not about
adding metrics to MirrorMaker. MirrorMaker consists of 3 connectors, and 2 of
them have metrics. This ticket is to be able to use the new APIs from KIP-877
in these connectors, instead of the hacky way they register metrics today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
