Yunyung commented on PR #19397: URL: https://github.com/apache/kafka/pull/19397#issuecomment-3458463053
> The point of this work is to figure out a way to do it, or find out it's not possible and decide to not add KIP-877 support to ConfigProvider. Wrapping ConfigProvider into Plugins and never providing metrics is not achieving anything. > ConfigProviders can be used by all Kafka components, Clients (producer, consumer, admin), Brokers, Controllers, Connect and Streams. I'm not sure I understand why you think having tests in WorkerTest is enough. @mimaison Thanks for the valuable feedback. After rethinking and checking the code in response to the two comments you mentioned, I found the following: - For clients (Producer, Consumer, Admin), brokers, controllers, MirrorMaker, and Streams, the ConfigProvider is used only once (Only at startup) in AbstractConfig's constructor and is closed immediately. See: https://github.com/apache/kafka/blob/76a1c839cf1f6e4ac2bc3317a73e65955428a1f6/clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java#L562 Therefore, monitoring them are not valuable. - For Connect, the ConfigProvider is long-lived, enabling dynamic connector configuration updates, config reloads, etc. Monitoring long-lived ConfigProviders is therefore valuable. Therefore, IMO, KIP-877 support for ConfigProvider is useful only for Connect. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
