mjsax commented on code in PR #19913:
URL: https://github.com/apache/kafka/pull/19913#discussion_r2162812021
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java:
##########
@@ -74,11 +76,14 @@ public class InternalTopicManager {
private final Time time;
private final Admin adminClient;
+ private final boolean isManualInternalTopicConfig;
private final short replicationFactor;
private final long windowChangeLogAdditionalRetention;
private final long retryBackOffMs;
private final long retryTimeoutMs;
+ private Duration initTimeout;
+ private boolean isInitializing = false;
Review Comment:
Ah, I see. Might be simpler to just add a `boolean` parameter to `makeReady`
and pass in `true` from `init()` and `false` from the other calls to it?
In the end, we don't need to track this as "state" (ie, member variable on
`InternalTopicManager`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
