k-apol commented on code in PR #19913:
URL: https://github.com/apache/kafka/pull/19913#discussion_r2146343971
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java:
##########
@@ -90,6 +92,8 @@ public InternalTopicManager(final Time time,
final StreamsConfig streamsConfig) {
this.time = time;
this.adminClient = adminClient;
+ this.isManualInternalTopicConfig =
streamsConfig.getString(StreamsConfig.INTERNAL_TOPIC_SETUP_CONFIG)
+
.equals(StreamsConfig.INTERNAL_TOPIC_SETUP_MANUAL);
Review Comment:
So the way you wrote this does functionally the same thing, but I'm
introducing some risk that can be avoided by just changing the order?
I think I understand, the constant is always going to be a reference to a
string value of some kind, even if we change the string later. But it's
possible that if someone isn't using this feature, or it's not defaulted etc.
that a crash is caused without good reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
