cmccabe commented on code in PR #19586: URL: https://github.com/apache/kafka/pull/19586#discussion_r2076270972
########## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java: ########## @@ -157,6 +200,30 @@ public void addToActiveBrokerCount(int brokerCountDelta) { public int activeBrokerCount() { return this.activeBrokerCount.get(); } + + public void setControlledShutdownBrokerCount(int brokerCount) { + this.controllerShutdownBrokerCount.set(brokerCount); + } + + public void addToControlledShutdownBrokerCount(int brokerCountDelta) { + this.controllerShutdownBrokerCount.addAndGet(brokerCountDelta); + } + + public int controlledShutdownBrokerCount() { + return this.controllerShutdownBrokerCount.get(); + } + + public void setBrokerRegistrationState(int brokerId, int brokerState) { Review Comment: we should be able to just pass the `BrokerRegistration` object to `setBrokerRegistrationState`, right? Or more likely pass the enum to here, and have a function to create the enum based on the `BrokerRegistration` object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org