frankvicky commented on code in PR #19400:
URL: https://github.com/apache/kafka/pull/19400#discussion_r2059683265
##########
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##########
@@ -1640,33 +1599,6 @@ public synchronized boolean close(final CloseOptions
options) throws IllegalArgu
return close(Optional.of(timeoutMs), options.leaveGroup);
}
- private Consumer<StreamThread> streamThreadLeaveConsumerGroup(final long
remainingTimeMs) {
Review Comment:
Hi @ableegoldman
Do you think we should keep this method?
Before KIP-1092, the consumer relied on
`admin#removeMembersFromConsumerGroup` to leave the group.
As https://github.com/apache/kafka/pull/19400#discussion_r2059386588 states,
if we want to pass `leaveGroup=false` and maintain the default behavior, I
think we should retain this method. Once a consumer is shut down and does not
leave the group, they must rely on the admin to remove them from the consumer
group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
