ableegoldman commented on code in PR #19400:
URL: https://github.com/apache/kafka/pull/19400#discussion_r2059383062
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1805,12 +1816,12 @@ private void completeShutdown(final boolean cleanRun) {
log.error("Failed to unsubscribe due to the following error: ", e);
}
try {
- mainConsumer.close();
+ mainConsumer.close(closeOptions);
} catch (final Throwable e) {
log.error("Failed to close consumer due to the following error:",
e);
}
try {
- restoreConsumer.close();
+ restoreConsumer.close(closeOptions);
Review Comment:
I think we should pass either DEFAULT or REMAIN_IN_GROUP in for the restore
consumer so it doesn't try to leave the group. If I'm remembering correctly,
when LEAVE_GROUP is used it always tries to send a leave group even if it's not
in a group, whereas with DEFAULT it will skip the leaveGroup if there's no
member id or the coordinator is unknown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
