ableegoldman commented on code in PR #19400:
URL: https://github.com/apache/kafka/pull/19400#discussion_r2059385075
##########
tools/src/test/java/org/apache/kafka/tools/ResetIntegrationTest.java:
##########
@@ -256,9 +255,8 @@ public void
testResetWhenLongSessionTimeoutConfiguredWithForceOption(final TestI
streams = new
KafkaStreams(setupTopologyWithoutIntermediateUserTopic(), streamsConfig);
streams.cleanUp();
- // Reset would fail since long session timeout has been configured
final boolean cleanResult = tryCleanGlobal(false, null, null, appID);
- assertFalse(cleanResult);
+ assertTrue(cleanResult);
Review Comment:
oh i see, I missed that we were passing `leaveGroup=true` to the consumer
before. Glad this test caught that, though maybe we should try to have a test
specifically to make sure the default leave group behavior isn't ever changed
by accident in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
