aliehsaeedii commented on code in PR #19450: URL: https://github.com/apache/kafka/pull/19450#discussion_r2056811156
########## streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java: ########## @@ -179,7 +179,11 @@ public void resume() { * or flushing state store get IO errors; such error should cause the thread to die */ @Override - public Map<TopicPartition, OffsetAndMetadata> prepareCommit() { + public Map<TopicPartition, OffsetAndMetadata> prepareCommit(final boolean clean) { + if (!clean) { Review Comment: I check the `clean` flag for accurate logs. Let's keep the `Collections.emptyMap()` when close clean to keep the logic as it is?! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org