ShivsundarR commented on code in PR #19192:
URL: https://github.com/apache/kafka/pull/19192#discussion_r1994170894
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -527,8 +533,12 @@ public CompletableFuture<Map<TopicIdPartition,
Acknowledgements>> commitSync(
* Enqueue an AcknowledgeRequestState to be picked up on the next poll.
*
* @param acknowledgementsMap The acknowledgements to commit
+ * @param defaultTimeoutMs Timeout which would be used when the request
is retried, i.e. if it fails with
Review Comment:
I have now used the existing way of passing in `deadlineMs`, but we also
instantiate a timeout variable based on the `remainingMs`, and this value would
be re-used for every successive reset. So effectively whenever a new set of
acknowledgements is sent, it will have a timeout of approximately 60 seconds
(i.e. the `defaultTimeoutApiMs`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
