AndrewJSchofield commented on code in PR #19108:
URL: https://github.com/apache/kafka/pull/19108#discussion_r1981863839
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##########
@@ -596,18 +599,29 @@ public static VerifiableShareConsumer
createFromArgs(ArgumentParser parser, Stri
StringDeserializer deserializer = new StringDeserializer();
KafkaShareConsumer<String, String> consumer = new
KafkaShareConsumer<>(consumerProps, deserializer, deserializer);
+ Properties adminClientProps = new Properties();
+ if (adminClientConfigFile != null) {
+ try {
+
adminClientProps.putAll(Utils.loadProps(adminClientConfigFile));
+ } catch (IOException e) {
+ throw new ArgumentParserException(e.getMessage(), parser);
+ }
+ }
+
+ adminClientProps.put(CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG,
brokerHostandPort);
Review Comment:
I think the point is that both consumer and admin client need to be
configurable. Probably the same configuration values in both cases. Using the
same config for both would work as far as I know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
