apoorvmittal10 commented on code in PR #19108:
URL: https://github.com/apache/kafka/pull/19108#discussion_r1981377611
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##########
@@ -596,18 +599,29 @@ public static VerifiableShareConsumer
createFromArgs(ArgumentParser parser, Stri
StringDeserializer deserializer = new StringDeserializer();
KafkaShareConsumer<String, String> consumer = new
KafkaShareConsumer<>(consumerProps, deserializer, deserializer);
+ Properties adminClientProps = new Properties();
+ if (adminClientConfigFile != null) {
+ try {
+
adminClientProps.putAll(Utils.loadProps(adminClientConfigFile));
+ } catch (IOException e) {
+ throw new ArgumentParserException(e.getMessage(), parser);
+ }
+ }
+
+ adminClientProps.put(CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG,
brokerHostandPort);
Review Comment:
It means sasl configs, should not they be same as passed in
`consumer.config` hence should we rename `consumer.config` to `client.config`
and have single config file, thoughts? We can have @AndrewJSchofield's opinion
as well but I am thinking on the line to have single config file instead of two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
