frankvicky commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r1972772565
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##########
@@ -275,6 +284,24 @@ public int memberEpoch() {
return memberEpoch;
}
+ /**
+ * @return the operation the consumer will perform on leaving the group.
+ *
+ * @see CloseOptions.GroupMembershipOperation
+ */
+ public CloseOptions.GroupMembershipOperation leaveGroupOperation() {
+ return leaveGroupOperation;
+ }
+
+ /**
+ * Sets the operation on consumer group membership that the consumer will
perform when closing.
+ * The {@link AbstractMembershipManager#leaveGroupOperation} should remain
{@code GroupMembershipOperation.DEFAULT}
+ * until the consumer is closed.
+ *
+ * @param operation the operation to be performed on close
+ */
+ public abstract void
leaveGroupOperationOnClose(CloseOptions.GroupMembershipOperation operation);
Review Comment:
Thanks for pointing out!
Previously, I thought it might have different implementations, but
eventually, they are identical.
I will fix it in the next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
