frankvicky commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r1972971591
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -301,12 +303,15 @@ public void close(final Duration timeout) {
* the network thread the time to close down cleanly.
*
* @param timeout Upper bound of time to wait for the network thread to
close its resources
+ * @param membershipOperation the operation on consumer group membership
that the consumer will perform when closing
*/
- private void closeInternal(final Duration timeout) {
+ private void closeInternal(final Duration timeout,
CloseOptions.GroupMembershipOperation membershipOperation) {
long timeoutMs = timeout.toMillis();
log.trace("Signaling the consumer network thread to close in {}ms",
timeoutMs);
running = false;
closeTimeout = timeout;
+ requestManagers.consumerMembershipManager.ifPresent(membershipManager
->
Review Comment:
Indeed, this is not elegant. I will see how to fix this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
