mjsax commented on code in PR #18883:
URL: https://github.com/apache/kafka/pull/18883#discussion_r1953776580


##########
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedKStream.java:
##########
@@ -217,23 +226,29 @@ KTable<Windowed<K>, Long> count(final Named named,
                                     final Materialized<K, Long, 
WindowStore<Bytes, byte[]>> materialized);
 
     /**
-     * Aggregate the values of records in this stream by the grouped key and 
defined windows.

Review Comment:
   The diff starting here is just "bad" and can be "ignored". I just re-ordered 
method, to align method order across different classes. There is no actual 
change below.
   
   Old older `count() - aggregate() - reduce()` vs new order `count() - 
reduce() -  aggregate()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to