mjsax commented on code in PR #18883:
URL: https://github.com/apache/kafka/pull/18883#discussion_r1953777496


##########
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedKStream.java:
##########
@@ -470,43 +478,43 @@ <VR> KTable<Windowed<K>, VR> aggregate(final 
Initializer<VR> initializer,
      * user-specified in {@link StreamsConfig} via parameter
      * {@link StreamsConfig#APPLICATION_ID_CONFIG APPLICATION_ID_CONFIG}, 
"internalStoreName" is an internal name
      * and "-changelog" is a fixed suffix.
+     * Note that the internal store name may not be queryable through 
Interactive Queries.
      * <p>
      * You can retrieve all generated internal topic names via {@link 
Topology#describe()}.
      *
-     * @param reducer  a {@link Reducer} that computes a new aggregate result. 
Cannot be {@code null}.
+     * @param initializer  an {@link Initializer} that computes an initial 
intermediate aggregation result. Cannot be {@code null}.
+     * @param aggregator   an {@link Aggregator} that computes a new aggregate 
result. Cannot be {@code null}.
+     * @param <VOut>         the value type of the resulting {@link KTable}
      * @return a windowed {@link KTable} that contains "update" records with 
unmodified keys, and values that represent
      * the latest (rolling) aggregate for each key within a window
      */
-    KTable<Windowed<K>, V> reduce(final Reducer<V> reducer);
+    <VOut> KTable<Windowed<K>, VOut> aggregate(final Initializer<VOut> 
initializer,

Review Comment:
   Minor change for aggregate overloads. Updated generic type from `VR` to 
`VOut`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to