frankvicky commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1954665776
########## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManagerTest.java: ########## @@ -663,7 +663,7 @@ public void testSameAssignmentReconciledAgainWithMissingTopic() { // stay in RECONCILING state, since an unresolved topic is assigned membershipManager.onHeartbeatSuccess(createConsumerGroupHeartbeatResponse(assignment1, membershipManager.memberId())); assertEquals(MemberState.RECONCILING, membershipManager.state()); - membershipManager.poll(time.milliseconds()); + membershipManager.maybeReconcile(true); Review Comment: I said we should replace all `membershipManager.poll()` in `ConsumerMembershipManagerTest` with `maybeReconcile` to avoid confusion. WDYT ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org