frankvicky commented on code in PR #18702:
URL: https://github.com/apache/kafka/pull/18702#discussion_r1940744792
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1326,7 +1331,7 @@ private void close(Duration timeout, boolean
swallowException) {
// We are already closing with a timeout, don't allow wake-ups from
here on.
wakeupTrigger.disableWakeups();
- final Timer closeTimer = time.timer(timeout);
+ final Timer closeTimer = createTimer(timeout);
Review Comment:
Yes, just walk through the corresponding logic of the classic consumer.
The callback on close doesn't consume the time for the timer, to align the
behavior, I think it's ok to remove the timer from
`runRebalanceCallbacksOnClose`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
