chia7712 commented on code in PR #18702:
URL: https://github.com/apache/kafka/pull/18702#discussion_r1940736112
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -153,7 +153,8 @@ public class CommonClientConfigs {
public static final String REQUEST_TIMEOUT_MS_DOC = "The configuration
controls the maximum amount of time the client will wait "
+ "for the response
of a request. If the response is not received before the timeout "
+ "elapses the client
will resend the request if necessary or fail the request if "
- + "retries are
exhausted.";
+ + "retries are
exhausted. This timeout also applies to the consumer close operation - "
+ + "even if a larger
timeout is specified for close, it will be limited by this value.";
Review Comment:
> isn't it enough to explain the behaviour on the close API java doc?
+1 to add docs to close API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
