ijuma commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1934356925


##########
clients/src/main/resources/common/message/ProduceRequest.json:
##########
@@ -44,7 +47,7 @@
   // transaction V2 (KIP_890 part 2) is enabled, the produce request will also 
include the function for a
   // AddPartitionsToTxn call. If V2 is disabled, the client can't use produce 
request version higher than 11 within
   // a transaction.
-  "validVersions": "3-12",
+  "validVersions": "0-12",

Review Comment:
   I am indeed exploring something involving customizing ApiKey/ApiResponse 
(that's what I meant when I said that there may be a cleaner way to make the 
change). But I was planning to leave 0-12 here and reduce the range within the 
code.
   
   The main advantage is that you get appropriate errors if you try to produce 
with v0-2. The option you suggest would result in a disconnection. I think a 
disconnection is too confusing if the given version is included as part of the 
api versions response.
   
   Thoughts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to